This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Change CI paths to varibles #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnoloughlin
force-pushed
the
ci_updates
branch
4 times, most recently
from
a84ed17 to
df702d0
Compare
johnoloughlin
force-pushed
the
ci_updates
branch
from
df702d0 to
842435d
Compare
Signed-off-by: John O'Loughlin <[email protected]>
johnoloughlin
force-pushed
the
ci_updates
branch
from
842435d to
d54c63b
Compare
Eoghan1232
reviewed
Nov 6, 2023
| CI_DIR="/runner/_work/userspace-cni-network-plugin/userspace-cni-network-plugin/ci/" | ||
| kubectl apply -f $CI_DIR/vpp_test_setup/network_attachment_definition.yaml | ||
| kubectl create -n vpp configmap vpp-app-startup-config --from-file=$CI_DIR/vpp_test_setup/startup.conf | ||
| # set CI_DIR if not defined in parent script |
There was a problem hiding this comment.
should a default just be set in parent dir instead?
There was a problem hiding this comment.
more modular for end user, allows user to run this script without the others
Eoghan1232
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.